catch_reporter_junit added xml attribute status #1899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added status xml attribute to testcase section. To be compatible with google test junit xml output
|
What does the status mean? |
|
@horenmar The status tells if this test case has been executed or not. In case of catch this should always be run I think. GoogleTest has the possibility to skip tests. |
|
Catch2 actually does sometimes skip tests (you can mark tests as throwing and ask Catch2 to skip throwing tests, and arguably you could say that tests not selected to be run are also skipped), and there is a reporter interface member function for that ( |
nitnelave
pushed a commit
to nitnelave/Catch2
that referenced
this pull request
May 25, 2020
This brings our output inline with GTest's. We do not handle skipped tests properly, but that should be currently less important than having the attribute exist with proper value for non-skipped tests. Thanks @joda-01. Closes catchorg#1899
cenit
pushed a commit
to physycom/Catch
that referenced
this pull request
Aug 8, 2020
This brings our output inline with GTest's. We do not handle skipped tests properly, but that should be currently less important than having the attribute exist with proper value for non-skipped tests. Thanks @joda-01. Closes catchorg#1899
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added "status" xml attribute to testcase section.
This is done to be compatible with google test junit xml output.